Bug 11908

Summary:	WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes
Product:	WebKit	Reporter:	Eric Seidel (no email) <eric>
Component:	SVG	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mitz
Priority:	P2
Version:	420+
Hardware:	Mac
OS:	OS X 10.4
URL:	http://xml2.mweb.co.za/clipart/plants/bamboo_01.svg
Bug Depends on:	11108
Bug Blocks:

Description Eric Seidel (no email) 2006-12-21 05:16:14 PST

WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes

This function:
bool SVGTransformable::parseTransformAttribute(SVGTransformList* list, const AtomicString& transform)

Uses a regex for parsing.  Ick.

that's eating 40% of our time while parsing, at least when displaying bamboo.svg  I think a simpler, custom parser is in order.

Comment 1 Eric Seidel (no email) 2006-12-21 05:17:19 PST

it's actually bamboo_01.svg

http://xml2.mweb.co.za/clipart/plants/bamboo_01.svg

Save it locally for proper testing.

Comment 2 mitz 2006-12-21 06:47:40 PST

(In reply to comment #0)

> I think a simpler, custom parser is in order.

See attachment 10944 [details] in bug 11108.

Comment 3 Rob Buis 2006-12-22 13:46:38 PST

Hi Eric, Mitz,

(In reply to comment #2)
> (In reply to comment #0)
> 
> > I think a simpler, custom parser is in order.
> 
> See attachment 10944 [details] [edit] in bug 11108.

I created a new patch that actually compiles on ToT :) I'd love it if someone could take it and shark it with bamboo.svg, since I am away for at least 24h.
Cheers,

Rob.

Comment 4 Rob Buis 2006-12-27 15:25:25 PST

Landed in r18440.

Comment 5 Rob Buis 2006-12-27 15:27:39 PST

Landed in r18440.