Bug 99740 - Generated messages should have a receiver name and a name
Summary: Generated messages should have a receiver name and a name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 11:41 PDT by Anders Carlsson
Modified: 2012-10-19 00:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.89 KB, patch)
2012-10-18 11:44 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-18 11:41:52 PDT 
Generated messages should have a receiver name and a name
Comment 1 Anders Carlsson 2012-10-18 11:44:28 PDT 
Created attachment 169445 [details]
Patch
Comment 2 Andreas Kling 2012-10-18 11:46:23 PDT 
Comment on attachment 169445 [details]
Patch

Oh hells yeah. r=me
Comment 3 Anders Carlsson 2012-10-18 11:53:01 PDT 
Committed r131784: <http://trac.webkit.org/changeset/131784>
Comment 4 Csaba Osztrogonác 2012-10-18 12:37:31 PDT 
It broke the Qt build. Will you fix it please?
You could have avoided it if you wait for the EWS.

andersca@apple.com 	2012-10-18 11:44:28 PST 	Attachment #169445 [details] Flag 		review?
kling@webkit.org 	2012-10-18 11:46:23 PST 	Attachment #169445 [details] Flag 	review? 	review+ 

Waiting only 2 minutes isn't enough ...
Comment 5 Csaba Osztrogonác 2012-10-18 12:39:37 PDT 
and EFL and GTK ...
Comment 6 Csaba Osztrogonác 2012-10-19 00:08:22 PDT 
... and buildfix landed in https://trac.webkit.org/changeset/131792 without any reference to this bug.