Bug 99684 - [EFL][WK2] Change the title of inspector window when inspected page is changed
Summary: [EFL][WK2] Change the title of inspector window when inspected page is changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 22:30 PDT by Seokju Kwon
Modified: 2012-10-19 23:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2012-10-17 23:30 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2012-10-19 04:05 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2012-10-17 22:30:24 PDT 
Implement function to change the title of inspector window.
Comment 1 Seokju Kwon 2012-10-17 23:30:18 PDT 
Created attachment 169350 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-10-19 02:45:58 PDT 
Comment on attachment 169350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review

LGTM.

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141
> +    String title = "Web Inspector-" + url;

Nit, maybe I would add a space before and after the dash.
Comment 3 Seokju Kwon 2012-10-19 04:05:05 PDT 
Created attachment 169595 [details]
Patch
Comment 4 Seokju Kwon 2012-10-19 04:06:09 PDT 
(In reply to comment #2)
> (From update of attachment 169350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review
> 
> LGTM.
> 
> > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141
> > +    String title = "Web Inspector-" + url;
> 
> Nit, maybe I would add a space before and after the dash.

Done. Thanks.
Comment 5 WebKit Review Bot 2012-10-19 23:28:53 PDT 
Comment on attachment 169595 [details]
Patch

Clearing flags on attachment: 169595

Committed r131980: <http://trac.webkit.org/changeset/131980>
Comment 6 WebKit Review Bot 2012-10-19 23:28:57 PDT 
All reviewed patches have been landed.  Closing bug.