RESOLVED FIXED 99684
[EFL][WK2] Change the title of inspector window when inspected page is changed 
https://bugs.webkit.org/show_bug.cgi?id=99684
Summary [EFL][WK2] Change the title of inspector window when inspected page is changed
Seokju Kwon
Reported 2012-10-17 22:30:24 PDT
Implement function to change the title of inspector window.
Attachments
Patch (1.61 KB, patch)
2012-10-17 23:30 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2012-10-19 04:05 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2012-10-17 23:30:18 PDT
Created attachment 169350 [details] Patch
Thiago Marcos P. Santos
Comment 2 2012-10-19 02:45:58 PDT
Comment on attachment 169350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review LGTM. > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141 > + String title = "Web Inspector-" + url; Nit, maybe I would add a space before and after the dash.
Seokju Kwon
Comment 3 2012-10-19 04:05:05 PDT
Created attachment 169595 [details] Patch
Seokju Kwon
Comment 4 2012-10-19 04:06:09 PDT
(In reply to comment #2) > (From update of attachment 169350 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review > > LGTM. > > > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141 > > + String title = "Web Inspector-" + url; > > Nit, maybe I would add a space before and after the dash. Done. Thanks.
WebKit Review Bot
Comment 5 2012-10-19 23:28:53 PDT
Comment on attachment 169595 [details] Patch Clearing flags on attachment: 169595 Committed r131980: <http://trac.webkit.org/changeset/131980>
WebKit Review Bot
Comment 6 2012-10-19 23:28:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.