Bug 99566 - Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
Summary: Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 99510
  Show dependency tree / graph
 
Reported: 2012-10-17 01:52 PDT by Hajime Morrita
Modified: 2012-10-17 02:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2012-10-17 02:11 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2012-10-17 02:25 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-10-17 01:52:33 PDT 
Reproduction and fix will come shortly.
Comment 1 Hajime Morrita 2012-10-17 02:11:08 PDT 
Created attachment 169131 [details]
Patch
Comment 2 Hajime Morrita 2012-10-17 02:12:29 PDT 
Kent-san, could this be worth a rubberstamp? I have another bug fix which is blocked by this.
Comment 3 Kent Tamura 2012-10-17 02:16:07 PDT 
Comment on attachment 169131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169131&action=review

The code change is ok.

> LayoutTests/ChangeLog:9
> +        * fast/forms/textarea/remove-while-focusing.html: Added.

Would you name this test "textarea-autofocus-removal-while-focusing.html" please?
Comment 4 Hajime Morrita 2012-10-17 02:25:36 PDT 
Created attachment 169135 [details]
Patch
Comment 5 Hajime Morrita 2012-10-17 02:26:07 PDT 
Comment on attachment 169135 [details]
Patch

Sure. Renamed the test.
Comment 6 Kent Tamura 2012-10-17 02:31:36 PDT 
Comment on attachment 169135 [details]
Patch

Thanks
Comment 7 WebKit Review Bot 2012-10-17 02:58:01 PDT 
Comment on attachment 169135 [details]
Patch

Clearing flags on attachment: 169135

Committed r131572: <http://trac.webkit.org/changeset/131572>
Comment 8 WebKit Review Bot 2012-10-17 02:58:04 PDT 
All reviewed patches have been landed.  Closing bug.