Bug 99375 – Add force parameter to DOMTokenList.toggle

Bug 99375 - Add force parameter to DOMTokenList.toggle


Summary:	Add force parameter to DOMTokenList.toggle

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	HTML DOM
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	Pablo Flouret

URL:
Keywords:	WebExposed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-10-15 15:47 PDT by Pablo Flouret
Modified:	2012-10-15 20:57 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (8.47 KB, patch) 2012-10-15 16:08 PDT, Pablo Flouret	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pablo Flouret 2012-10-15 15:47:40 PDT

https://www.w3.org/Bugs/Public/show_bug.cgi?id=18463

The optional boolean force parameter, if present, basically makes toggle always add or remove a class.

Comment 1 Pablo Flouret 2012-10-15 16:08:21 PDT

Created attachment 168797 [details]
Patch

Comment 2 Darin Adler 2012-10-15 20:39:45 PDT

Comment on attachment 168797 [details]
Patch

Code change looks fine. Test cases are not nearly extensive enough. We should do the toggle version of all the add and remove tests, plus we need to check the behavior when the argument is a non-boolean JavaScript value such as the numbers 0 and 1, null, undefined, or a string.

Comment 3 WebKit Review Bot 2012-10-15 20:57:05 PDT

Comment on attachment 168797 [details]
Patch

Clearing flags on attachment: 168797

Committed r131408: <http://trac.webkit.org/changeset/131408>

Comment 4 WebKit Review Bot 2012-10-15 20:57:09 PDT

All reviewed patches have been landed.  Closing bug.