Bug 99095 - Add some initial visible rect tests and tweak the visible wash layer
Summary: Add some initial visible rect tests and tweak the visible wash layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 13:38 PDT by Simon Fraser (smfr)
Modified: 2012-10-12 18:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (25.12 KB, patch)
2012-10-11 14:17 PDT, Simon Fraser (smfr)
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-11 13:38:41 PDT
Add some initial visible rect tests and tweak the visible wash layer
Comment 1 Simon Fraser (smfr) 2012-10-11 14:17:20 PDT
Created attachment 168276 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-11 14:20:12 PDT
Attachment 168276 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/comp..." exit_code: 1
LayoutTests/platform/chromium/TestExpectations:672:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium-android/TestExpectations:72:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:317:  Test lacks BUG modifier.  [test/expectations] [5]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2012-10-11 14:25:15 PDT
Comment on attachment 168276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168276&action=review

> LayoutTests/ChangeLog:11
> +        Skip these tests on platforms that don't log layer visible rects
> +        (all non-Mac).

Do you expect this to change, or should the tests be platform-specific tests?

> LayoutTests/compositing/visible-rect/clipped-by-viewport copy.html:1
> +<!DOCTYPE html>

what's with the filename? did you mean to add this file (and its -expected?)
Comment 4 Build Bot 2012-10-11 15:00:36 PDT
Comment on attachment 168276 [details]
Patch

Attachment 168276 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14255695

New failing tests:
compositing/visible-rect/3d-transformed.html
Comment 5 WebKit Review Bot 2012-10-11 21:24:02 PDT
Comment on attachment 168276 [details]
Patch

Attachment 168276 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14253843

New failing tests:
platform/chromium/virtual/softwarecompositing/visible-rect/3d-transformed.html
platform/chromium/virtual/softwarecompositing/visible-rect/clipped-by-viewport.html
platform/chromium/virtual/softwarecompositing/visible-rect/2d-transformed.html
platform/chromium/virtual/softwarecompositing/visible-rect/clipped-visible-rect.html
Comment 6 Simon Fraser (smfr) 2012-10-12 18:17:57 PDT
http://trac.webkit.org/changeset/131246