Bug 98995 - [Chromium][Mac] r130994 seems to break chromium gpu test
Summary: [Chromium][Mac] r130994 seems to break chromium gpu test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Novosad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 23:19 PDT by Shinya Kawanaka
Modified: 2012-10-11 07:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2012-10-11 07:24 PDT, Justin Novosad
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-10-10 23:19:24 PDT
Seeing http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20%28dbg%29/builds/9209,
r130994 broke the chromium test.
Comment 1 Justin Novosad 2012-10-11 07:02:39 PDT
This assertion fires because there is a built-in assumption that 2d canvas operations are always triggered from within a WebThread task.  This test appears to be an exception to that assumption.
Comment 2 Justin Novosad 2012-10-11 07:24:51 PDT
Created attachment 168225 [details]
Patch
Comment 3 Stephen White 2012-10-11 07:25:27 PDT
Comment on attachment 168225 [details]
Patch

OK.  r=me
Comment 4 WebKit Review Bot 2012-10-11 07:49:57 PDT
Comment on attachment 168225 [details]
Patch

Clearing flags on attachment: 168225

Committed r131059: <http://trac.webkit.org/changeset/131059>
Comment 5 WebKit Review Bot 2012-10-11 07:50:00 PDT
All reviewed patches have been landed.  Closing bug.