Bug 98321 - Standardize on "flush" terminology for compositing layer flushing/syncing
Summary: Standardize on "flush" terminology for compositing layer flushing/syncing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 16:34 PDT by Simon Fraser (smfr)
Modified: 2012-10-04 09:16 PDT (History)
13 users (show)

See Also:


Attachments
Patch (38.17 KB, patch)
2012-10-03 16:37 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (43.97 KB, patch)
2012-10-03 18:06 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-03 16:34:26 PDT
Standardize on "flush" terminology for compositing layer flushing/syncing
Comment 1 Simon Fraser (smfr) 2012-10-03 16:37:11 PDT
Created attachment 166989 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-03 16:39:51 PDT
Attachment 166989 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/loader/EmptyClients.h:196:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 1 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-10-03 17:00:50 PDT
Comment on attachment 166989 [details]
Patch

Attachment 166989 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14138765
Comment 4 Build Bot 2012-10-03 17:15:44 PDT
Comment on attachment 166989 [details]
Patch

Attachment 166989 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14134767
Comment 5 Early Warning System Bot 2012-10-03 17:23:55 PDT
Comment on attachment 166989 [details]
Patch

Attachment 166989 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14152296
Comment 6 Simon Fraser (smfr) 2012-10-03 18:06:14 PDT
Created attachment 167013 [details]
Patch
Comment 7 Simon Fraser (smfr) 2012-10-03 19:52:49 PDT
Comment on attachment 167013 [details]
Patch

Bring Tim's r+ forward
Comment 8 WebKit Review Bot 2012-10-04 09:16:10 PDT
Comment on attachment 167013 [details]
Patch

Clearing flags on attachment: 167013

Committed r130400: <http://trac.webkit.org/changeset/130400>
Comment 9 WebKit Review Bot 2012-10-04 09:16:14 PDT
All reviewed patches have been landed.  Closing bug.