Bug 98011 - [Qt] Enable mock scrollbars
Summary: [Qt] Enable mock scrollbars
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67217 79666 94800
  Show dependency treegraph
 
Reported: 2012-10-01 04:03 PDT by Balazs Kelemen
Modified: 2012-10-03 07:36 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2012-10-01 04:07 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-10-01 04:03:23 PDT
I would like to enable this to reduce the gardening need for Qt. This will be extremely useful for pixel tests.
Comment 1 Balazs Kelemen 2012-10-01 04:07:37 PDT
Created attachment 166445 [details]
Patch
Comment 2 Balazs Kelemen 2012-10-01 04:13:29 PDT
This patch require rebaselining both the text and pixel dump of tests with scrollbar. The text differs because the mock scrollbar is less thick than the default (on linux) with one single pixel.
Comment 3 Csaba Osztrogonác 2012-10-01 04:19:34 PDT
Comment on attachment 166445 [details]
Patch

r=me, but CQ-, we will land it with rebaselining.
Comment 4 Csaba Osztrogonác 2012-10-03 07:10:47 PDT
Comment on attachment 166445 [details]
Patch

Landed in https://trac.webkit.org/changeset/130283
Comment 5 Csaba Osztrogonác 2012-10-03 07:36:20 PDT
Rebaseing patch landed in https://trac.webkit.org/changeset/130286