Bug 97872 - [Refactoring] DOMSelection should not use shadowAncestorNode
Summary: [Refactoring] DOMSelection should not use shadowAncestorNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 91821
  Show dependency tree / graph
 
Reported: 2012-09-28 00:06 PDT by Shinya Kawanaka
Modified: 2012-10-01 23:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-09-28 00:12 PDT, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-09-28 00:06:43 PDT 
in selectionShadowAncestor, we're using node->shadowAncestorNode(), but it's deprecated.
We should use TreeScope::ancestorInThisScope here.
Comment 1 Shinya Kawanaka 2012-09-28 00:12:25 PDT 
Created attachment 166159 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-10-01 14:53:52 PDT 
+1
Comment 3 WebKit Review Bot 2012-10-01 23:22:20 PDT 
Comment on attachment 166159 [details]
Patch

Clearing flags on attachment: 166159

Committed r130124: <http://trac.webkit.org/changeset/130124>
Comment 4 WebKit Review Bot 2012-10-01 23:22:23 PDT 
All reviewed patches have been landed.  Closing bug.