Bug 97821 - [GTK] Enable CSS Shaders layout LayoutTests on GTK+
Summary: [GTK] Enable CSS Shaders layout LayoutTests on GTK+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 13:56 PDT by Dongseong Hwang
Modified: 2012-09-28 06:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.10 KB, patch)
2012-09-27 14:03 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-09-27 13:56:26 PDT
Enable CSS Shaders layout LayoutTests on GTK+
Comment 1 Dongseong Hwang 2012-09-27 14:03:33 PDT
Created attachment 166061 [details]
Patch
Comment 2 Dongseong Hwang 2012-09-27 14:05:21 PDT
All custom filter layout tests pass in WebKit1:  css3/filters/custom
One test fails in WebKit2: css3/filters/custom/filter-fallback-to-software.html
Comment 3 Martin Robinson 2012-09-27 14:09:58 PDT
Comment on attachment 166061 [details]
Patch

Perhaps this patch could also unskip the tests?
Comment 4 Dongseong Hwang 2012-09-28 01:56:13 PDT
(In reply to comment #3)
> (From update of attachment 166061 [details])
> Perhaps this patch could also unskip the tests?

GTK skipped css3/filters, so I hesitated to unskip css3/filters/custom. Could I unskip css3/filters/custom although css3/filters are skipped?

In addition, Nvidia machine can not run the layout tests using GraphicsContext3D because of Xvfb issues.
Comment 5 Martin Robinson 2012-09-28 06:43:56 PDT
Makes sense!
Comment 6 WebKit Review Bot 2012-09-28 06:49:30 PDT
Comment on attachment 166061 [details]
Patch

Clearing flags on attachment: 166061

Committed r129888: <http://trac.webkit.org/changeset/129888>
Comment 7 WebKit Review Bot 2012-09-28 06:49:33 PDT
All reviewed patches have been landed.  Closing bug.