Bug 97217 - -webkit-clip-path is applied on elements that are not descendant of the container
Summary: -webkit-clip-path is applied on elements that are not descendant of the conta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks: 95389 97325 105883
  Show dependency tree / graph
 
Reported: 2012-09-20 08:09 PDT by Alexandru Chiculita
Modified: 2012-12-31 04:35 PST (History)
10 users (show)

See Also:

Attachments
Test case (663 bytes, text/html)
2012-09-20 08:15 PDT, Alexandru Chiculita 		no flags Details
Patch V1 (4.51 KB, patch)
2012-09-21 02:18 PDT, Alexandru Chiculita 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch V2 (38.59 KB, patch)
2012-09-21 04:36 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-09-20 08:09:09 PDT 
The clip-path is not removed from the GraphicsContext when RenderLayer::paintLayerContents ends.
Comment 1 Alexandru Chiculita 2012-09-20 08:15:49 PDT 
Created attachment 164922 [details]
Test case
Comment 2 Alexandru Chiculita 2012-09-21 02:18:46 PDT 
Created attachment 165087 [details]
Patch V1
Comment 3 WebKit Review Bot 2012-09-21 03:06:05 PDT 
Comment on attachment 165087 [details]
Patch V1

Attachment 165087 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13953530

New failing tests:
css3/masking/clip-path-circle-relative-overflow.html
css3/masking/clip-path-circle-overflow.html
Comment 4 Alexandru Chiculita 2012-09-21 04:36:11 PDT 
Created attachment 165117 [details]
Patch V2
Comment 5 Dirk Schulze 2012-09-21 05:00:40 PDT 
Comment on attachment 165117 [details]
Patch V2

Great catch! LGTM. r=me.
Comment 6 WebKit Review Bot 2012-09-21 05:07:45 PDT 
Comment on attachment 165117 [details]
Patch V2

Clearing flags on attachment: 165117

Committed r129215: <http://trac.webkit.org/changeset/129215>
Comment 7 WebKit Review Bot 2012-09-21 05:07:50 PDT 
All reviewed patches have been landed.  Closing bug.