Bug 96540 - [EFL] Compilation error in RenderThemeEfl.cpp
Summary: [EFL] Compilation error in RenderThemeEfl.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 96501
  Show dependency tree / graph
 
Reported: 2012-09-12 12:10 PDT by Chris Dumez
Modified: 2012-09-12 13:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2012-09-12 12:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-12 12:10:24 PDT 
We get the following error on the EFL debug build bot:
Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/RenderThemeEfl.cpp.o
Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/ScrollbarEfl.cpp.o
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp: In member function ‘WTF::String WebCore::RenderThemeEfl::themePath() const’:
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp:495:14: error: passing ‘const WebCore::RenderThemeEfl’ as ‘this’ argument of ‘Evas_Object* WebCore::RenderThemeEfl::edje()’ discards qualifiers [-fpermissive]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp:497:35: error: passing ‘const WebCore::RenderThemeEfl’ as ‘this’ argument of ‘Evas_Object* WebCore::RenderThemeEfl::edje()’ discards qualifiers [-fpermissive]
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/RenderThemeEfl.cpp.o] Error 1
Comment 1 Chris Dumez 2012-09-12 12:12:19 PDT 
Created attachment 163669 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-09-12 12:32:52 PDT 
Thanks for fixing Chris!
Comment 3 WebKit Review Bot 2012-09-12 12:41:23 PDT 
Comment on attachment 163669 [details]
Patch

Clearing flags on attachment: 163669

Committed r128350: <http://trac.webkit.org/changeset/128350>
Comment 4 WebKit Review Bot 2012-09-12 12:41:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Sudarsana Nagineni (babu) 2012-09-12 13:44:16 PDT 
Thanks for the fix, Chris.