Bug 96336 - [V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions
Summary: [V8] createFunctionOnlyCallback should be in V8Callback.h with the other call...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 16:43 PDT by Adam Barth
Modified: 2012-09-10 17:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.17 KB, patch)
2012-09-10 16:44 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-10 16:43:27 PDT 
[V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions
Comment 1 Adam Barth 2012-09-10 16:44:29 PDT 
Created attachment 163244 [details]
Patch
Comment 2 Kentaro Hara 2012-09-10 16:45:47 PDT 
Comment on attachment 163244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163244&action=review

> Source/WebCore/ChangeLog:9
> +        setTypeMismatchException because we no longer have a header inclusion

Good refactoring. I've wanted to remove it for months:)
Comment 3 WebKit Review Bot 2012-09-10 17:40:51 PDT 
Comment on attachment 163244 [details]
Patch

Clearing flags on attachment: 163244

Committed r128135: <http://trac.webkit.org/changeset/128135>
Comment 4 WebKit Review Bot 2012-09-10 17:40:54 PDT 
All reviewed patches have been landed.  Closing bug.