Bug 96092 - MediaStream API: add RTCPeerConnection::createAnswer
Summary: MediaStream API: add RTCPeerConnection::createAnswer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords: WebExposed
Depends on:
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-09-07 03:45 PDT by Tommy Widenflycht
Modified: 2012-09-07 12:30 PDT (History)
10 users (show)

See Also:


Attachments
Patch (24.99 KB, patch)
2012-09-07 03:54 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-09-07 03:45:20 PDT
Also, clean up the local and remote description tests a bit.
Comment 1 Tommy Widenflycht 2012-09-07 03:54:32 PDT
Created attachment 162732 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-07 03:57:12 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-09-07 10:28:37 PDT
Comment on attachment 162732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162732&action=review

> Source/WebCore/ChangeLog:8
> +        MediaStream API: add RTCPeerConnection::createAnswer
> +        https://bugs.webkit.org/show_bug.cgi?id=96092
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/mediastream/RTCPeerConnection-createAnswer.html

It would be nice to have more information in these ChangeLogs.  I know there isn't much to say, but perhaps a link to the part of the spec that defines this stuff?
Comment 4 WebKit Review Bot 2012-09-07 12:30:33 PDT
Comment on attachment 162732 [details]
Patch

Clearing flags on attachment: 162732

Committed r127906: <http://trac.webkit.org/changeset/127906>
Comment 5 WebKit Review Bot 2012-09-07 12:30:37 PDT
All reviewed patches have been landed.  Closing bug.