Bug 96086 - Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
Summary: Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 02:30 PDT by Ilya Tikhonovsky
Modified: 2012-09-07 05:10 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.15 KB, patch)
2012-09-07 02:36 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (5.15 KB, patch)
2012-09-07 02:50 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-07 02:30:44 PDT
It is a mandatory step before moving core code to WTF.
Comment 1 Ilya Tikhonovsky 2012-09-07 02:36:02 PDT
Created attachment 162715 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-07 02:44:59 PDT
Comment on attachment 162715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162715&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:35
> +#include <stdio.h>

Remove this.
Comment 3 Ilya Tikhonovsky 2012-09-07 02:50:32 PDT
Created attachment 162718 [details]
Patch
Comment 4 Yury Semikhatsky 2012-09-07 05:04:31 PDT
Comment on attachment 162718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162718&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:203
> +    MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = 0, size_t actualSize = 0)

objectType = 0 -> objectType = GenericMemoryTypes::Undefined
Comment 5 Ilya Tikhonovsky 2012-09-07 05:10:04 PDT
Committed r127856: <http://trac.webkit.org/changeset/127856>