RESOLVED FIXED 96025
[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll 
https://bugs.webkit.org/show_bug.cgi?id=96025
Summary [chromium] Export public functions on WebTransformationMatrix so they can be ...
James Robinson
Reported 2012-09-06 14:18:36 PDT
[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
Attachments
Patch (7.78 KB, patch)
2012-09-06 14:18 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-09-06 14:18:48 PDT
Created attachment 162582 [details] Patch
WebKit Review Bot
Comment 2 2012-09-06 14:21:22 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-09-06 14:21:38 PDT
Attachment 162582 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/Platform/chromium/public/WebTransformationMatrix.h:49: The parameter name "b" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebTransformationMatrix.h:49: The parameter name "d" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebTransformationMatrix.h:49: The parameter name "e" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Shawn Singh
Comment 4 2012-09-06 14:24:33 PDT
unofficially LGTM. For some reason I thought we already had done this =) The style errors are the same we encountered before, but if I recall, we agreed to keep the names there.
James Robinson
Comment 5 2012-09-06 14:25:58 PDT
Yeah, I think one-letter vars for matrix initialization are pretty reasonable.
Adrienne Walker
Comment 6 2012-09-06 14:28:24 PDT
Comment on attachment 162582 [details] Patch R=me.
James Robinson
Comment 7 2012-09-06 16:20:54 PDT
Committed r127796: <http://trac.webkit.org/changeset/127796>
Note You need to log in before you can comment on or make changes to this bug.