Bug 96021 - [chromium] Split platform geometry types into separate static target
Summary: [chromium] Split platform geometry types into separate static target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 14:05 PDT by James Robinson
Modified: 2012-09-06 14:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2012-09-06 14:06 PDT, James Robinson 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-09-06 14:05:20 PDT 
[chromium] Split platform geometry types into separate static target
Comment 1 James Robinson 2012-09-06 14:06:25 PDT 
Created attachment 162578 [details]
Patch
Comment 2 James Robinson 2012-09-06 14:08:21 PDT 
Chop chop!
Comment 3 Tony Chang 2012-09-06 14:18:41 PDT 
Comment on attachment 162578 [details]
Patch

Seems fine, but when adding a new file to platform/graphics, how does one know where to put it?
Comment 4 James Robinson 2012-09-06 14:20:26 PDT 
If a build breaks somewhere, I'll fix it :).  I expect this situation to be temporary and we don't add many new files.
Comment 5 James Robinson 2012-09-06 14:20:40 PDT 
"this situation" = statically linking against this target from elsewhere.
Comment 6 James Robinson 2012-09-06 14:44:29 PDT 
Committed r127787: <http://trac.webkit.org/changeset/127787>