WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
96021
[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021
Summary
[chromium] Split platform geometry types into separate static target
James Robinson
Reported
2012-09-06 14:05:20 PDT
[chromium] Split platform geometry types into separate static target
Attachments
Patch
(6.21 KB, patch)
2012-09-06 14:06 PDT
,
James Robinson
tony
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-09-06 14:06:25 PDT
Created
attachment 162578
[details]
Patch
James Robinson
Comment 2
2012-09-06 14:08:21 PDT
Chop chop!
Tony Chang
Comment 3
2012-09-06 14:18:41 PDT
Comment on
attachment 162578
[details]
Patch Seems fine, but when adding a new file to platform/graphics, how does one know where to put it?
James Robinson
Comment 4
2012-09-06 14:20:26 PDT
If a build breaks somewhere, I'll fix it :). I expect this situation to be temporary and we don't add many new files.
James Robinson
Comment 5
2012-09-06 14:20:40 PDT
"this situation" = statically linking against this target from elsewhere.
James Robinson
Comment 6
2012-09-06 14:44:29 PDT
Committed
r127787
: <
http://trac.webkit.org/changeset/127787
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug