RESOLVED FIXED95895
[Qt] Deprecate String += operator 
https://bugs.webkit.org/show_bug.cgi?id=95895
Summary [Qt] Deprecate String += operator
Lauro Moura Maranhao Neto
Reported 2012-09-05 14:35:31 PDT
WTF::String::operator+= is being removed.
Attachments
Patch (1.55 KB, patch)
2012-09-05 16:33 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
Patch (2.55 KB, patch)
2012-09-06 12:08 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura Maranhao Neto
Comment 1 2012-09-05 16:33:17 PDT
Created attachment 162366 [details] Patch Partial patch. Probably will need to be updated to remove PLATFORM(QT) from the guard added by #95797.
Lauro Moura Maranhao Neto
Comment 2 2012-09-05 16:35:23 PDT
(In reply to comment #1) > Created an attachment (id=162366) [details] > Patch > > Partial patch. Probably will need to be updated to remove PLATFORM(QT) from the guard added by #95797. s/added/will be added/ (but it's already on EWS)
Benjamin Poulain
Comment 3 2012-09-05 17:17:58 PDT
Comment on attachment 162366 [details] Patch Looks good.
Lauro Moura Maranhao Neto
Comment 4 2012-09-06 12:08:09 PDT
Created attachment 162551 [details] Patch Updated the test removing QT from the guard.
Benjamin Poulain
Comment 5 2012-09-06 12:12:15 PDT
Comment on attachment 162551 [details] Patch Yeah! Have checked the debug build, if yes we can cq+.
WebKit Review Bot
Comment 6 2012-09-06 16:54:27 PDT
Comment on attachment 162551 [details] Patch Clearing flags on attachment: 162551 Committed r127802: <http://trac.webkit.org/changeset/127802>
WebKit Review Bot
Comment 7 2012-09-06 16:54:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.