WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95520
[chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
https://bugs.webkit.org/show_bug.cgi?id=95520
Summary
[chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
James Robinson
Reported
2012-08-30 18:50:51 PDT
[chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
Attachments
Patch
(22.81 KB, patch)
2012-08-30 18:52 PDT
,
James Robinson
fishd
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-08-30 18:52:08 PDT
Created
attachment 161603
[details]
Patch
James Robinson
Comment 2
2012-08-30 18:53:26 PDT
Sadly the chromium side scoped_ptr<> -> WebPassOwnPtr<> conversion isn't working, at least on cr-linux clang. I'll try to investigate this when I get time but I need to make progress on WebCompositorSupport, so reverting to raw ptrs for now.
WebKit Review Bot
Comment 3
2012-08-30 18:55:06 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
James Robinson
Comment 4
2012-08-30 20:30:26 PDT
Committed
r127225
: <
http://trac.webkit.org/changeset/127225
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug