RESOLVED FIXED95401
[chromium] Make webkit_compositor specific unit test compilation conditional on gyp var 
https://bugs.webkit.org/show_bug.cgi?id=95401
Summary [chromium] Make webkit_compositor specific unit test compilation conditional ...
James Robinson
Reported 2012-08-29 16:45:22 PDT
[chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
Attachments
Patch (10.43 KB, patch)
2012-08-29 16:45 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (10.64 KB, patch)
2012-08-29 18:09 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-29 16:45:54 PDT
Created attachment 161358 [details] Patch
James Robinson
Comment 2 2012-08-29 16:48:52 PDT
Herpy derpy werpity do.
Nat Duca
Comment 3 2012-08-29 16:59:03 PDT
I don't see any stl in here... herpy makes me think of stds. LGTM though. :)
James Robinson
Comment 4 2012-08-29 18:06:03 PDT
Comment on attachment 161358 [details] Patch I got a bit overeager - some of those tests shouldn't really be guarded. Will refresh.
James Robinson
Comment 5 2012-08-29 18:09:42 PDT
Created attachment 161378 [details] Patch
James Robinson
Comment 6 2012-08-29 18:10:31 PDT
This moves ImageLayerChromiumTest, ContentLayerChromiumTest, ScrollbarLayerChromiumTest and WebCompositorInputHandlerImplTest back. The first two are misnamed and shouldn't be in this new category (or have their current names). The second two should move, but they'll need a bit of work first - I'm not quite ready to move 'em.
James Robinson
Comment 7 2012-08-30 13:01:34 PDT
Comment on attachment 161378 [details] Patch Clearing flags on attachment: 161378 Committed r127175: <http://trac.webkit.org/changeset/127175>
James Robinson
Comment 8 2012-08-30 13:01:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.