Bug 95367 – [New Multicolumn] Implement hit testing of columns

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Implement nodeAtPoint for RenderMultiColumnSet.

[Dave Hyatt]

Created attachment 161283 [details]
Patch

[WebKit Review Bot]

Attachment 161283 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderMultiColumnSet.cpp:273:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 161283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161283&action=review

> Source/WebCore/ChangeLog:9
> +        Add an implementation of nodeAtPoint for RenderMultiColumnSet that works similarly to painting.
> +        Multiple calls get made as you walk through the columns to hitTestFlowThreadPortionInRegion.

Would be nice to have some testcases, which you can do with elementFromPoint().

[Dave Hyatt]

Note test cases exist that cover this stuff. They just use the old columns code. My approach has been to test them by hand just to make sure they'll pass when we flip the switch. At any rate, before any of this code can turned on, it will have to fully pass the entire multicolumn test suite that we already have checked in, so in that sense the code does have tests that are there and that will have to be passed.

[Dave Hyatt]

Fixed in r127037.