WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95186
[EFL] Rename knob images to thumb on the default theme
https://bugs.webkit.org/show_bug.cgi?id=95186
Summary
[EFL] Rename knob images to thumb on the default theme
Thiago Marcos P. Santos
Reported
2012-08-28 03:15:30 PDT
WebKit reefers to these handles as thumb instead of knob. Let's make it coherent on EFL.
Attachments
Patch
(14.53 KB, patch)
2012-08-28 03:43 PDT
,
Thiago Marcos P. Santos
no flags
Details
Formatted Diff
Diff
Patch
(14.55 KB, patch)
2012-08-28 04:37 PDT
,
Thiago Marcos P. Santos
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1
2012-08-28 03:43:58 PDT
Created
attachment 160947
[details]
Patch
WebKit Review Bot
Comment 2
2012-08-28 03:48:00 PDT
Comment on
attachment 160947
[details]
Patch Rejecting
attachment 160947
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/efl/DefaultTheme/widget/slider/slider.edc.rej rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_h.png' rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_h.png' rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_v.png' rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_v.png' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/13656183
Thiago Marcos P. Santos
Comment 3
2012-08-28 04:37:08 PDT
Created
attachment 160951
[details]
Patch Re-uploading. The dependency for this patch just landed.
WebKit Review Bot
Comment 4
2012-08-28 05:25:06 PDT
Comment on
attachment 160951
[details]
Patch Clearing flags on attachment: 160951 Committed
r126868
: <
http://trac.webkit.org/changeset/126868
>
WebKit Review Bot
Comment 5
2012-08-28 05:25:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug