Bug 95186 - [EFL] Rename knob images to thumb on the default theme
Summary: [EFL] Rename knob images to thumb on the default theme
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 94595
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-28 03:15 PDT by Thiago Marcos P. Santos
Modified: 2012-08-28 05:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.53 KB, patch)
2012-08-28 03:43 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Patch (14.55 KB, patch)
2012-08-28 04:37 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-28 03:15:30 PDT 
WebKit reefers to these handles as thumb instead of knob. Let's make it coherent on EFL.
Comment 1 Thiago Marcos P. Santos 2012-08-28 03:43:58 PDT 
Created attachment 160947 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-28 03:48:00 PDT 
Comment on attachment 160947 [details]
Patch

Rejecting attachment 160947 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/efl/DefaultTheme/widget/slider/slider.edc.rej
rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_h.png'
rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_h.png'
rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_v.png'
rm 'Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_v.png'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13656183
Comment 3 Thiago Marcos P. Santos 2012-08-28 04:37:08 PDT 
Created attachment 160951 [details]
Patch

Re-uploading. The dependency for this patch just landed.
Comment 4 WebKit Review Bot 2012-08-28 05:25:06 PDT 
Comment on attachment 160951 [details]
Patch

Clearing flags on attachment: 160951

Committed r126868: <http://trac.webkit.org/changeset/126868>
Comment 5 WebKit Review Bot 2012-08-28 05:25:11 PDT 
All reviewed patches have been landed.  Closing bug.