Replace one horrible hack to make XPC services work, with a slightly less, slightly more, horrible hack
Created attachment 160883 [details] Patch
Comment on attachment 160883 [details] Patch This hack is too horrible for me. Removing from review.
Comment on attachment 160883 [details] Patch Attachment 160883 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13661431
Created attachment 165186 [details] Patch
Attachment 165186 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.h:44: The parameter name "connection" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 165186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165186&action=review > Source/WebKit2/ChangeLog:14 > + the AppSandbox. App Sandbox, unless you're talking about the MacOSX feature. > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:127 > + xpc_connection_set_event_handler(connection, ^(xpc_object_t event) { }); Please add a comment indicating why the block is empty here. > Source/WebKit2/WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:54 > + NSLog(@"re-exec"); :|
Committed r129293: <http://trac.webkit.org/changeset/129293>