Bug 95161 - WebProcess XPC services need have their environment set without disrupting all other XPC services
Summary: WebProcess XPC services need have their environment set without disrupting al...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
Depends on:
Reported: 2012-08-27 18:39 PDT by Sam Weinig
Modified: 2012-09-21 19:21 PDT (History)
1 user (show)

See Also:

Patch (20.88 KB, patch)
2012-08-27 19:17 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (90.71 KB, patch)
2012-09-21 13:57 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-08-27 18:39:09 PDT
Replace one horrible hack to make XPC services work, with a slightly less, slightly more, horrible hack
Comment 1 Sam Weinig 2012-08-27 19:17:50 PDT
Created attachment 160883 [details]
Comment 2 Sam Weinig 2012-08-27 20:04:12 PDT
Comment on attachment 160883 [details]

This hack is too horrible for me.  Removing from review.
Comment 3 Build Bot 2012-08-28 15:09:19 PDT
Comment on attachment 160883 [details]

Attachment 160883 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13661431
Comment 4 Sam Weinig 2012-09-21 13:57:59 PDT
Created attachment 165186 [details]
Comment 5 WebKit Review Bot 2012-09-21 14:02:09 PDT
Attachment 165186 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.h:44:  The parameter name "connection" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 13 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2012-09-21 14:23:16 PDT
Comment on attachment 165186 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=165186&action=review

> Source/WebKit2/ChangeLog:14
> +        the AppSandbox.

App Sandbox, unless you're talking about the MacOSX feature.

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:127
> +    xpc_connection_set_event_handler(connection, ^(xpc_object_t event) { });

Please add a comment indicating why the block is empty here.

> Source/WebKit2/WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:54
> +                NSLog(@"re-exec");

Comment 7 Sam Weinig 2012-09-21 19:21:59 PDT
Committed r129293: <http://trac.webkit.org/changeset/129293>