Bug 95110 - [Chromium] Fixing infinite recursion in Canvas2DLayerManager
Summary: [Chromium] Fixing infinite recursion in Canvas2DLayerManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Novosad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 11:58 PDT by Justin Novosad
Modified: 2012-08-27 13:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.13 KB, patch)
2012-08-27 12:05 PDT, Justin Novosad 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Novosad 2012-08-27 11:58:30 PDT 
[Chromium] Fixing infinite recursion in Canvas2DLayerManager
Comment 1 Justin Novosad 2012-08-27 12:05:12 PDT 
Created attachment 160767 [details]
Patch
Comment 2 Stephen White 2012-08-27 12:08:05 PDT 
Comment on attachment 160767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160767&action=review

r=me

> Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp:128
>      m_bytesAllocated -= bytesFreed;

Micronit:  this could be in the if-clause too.

> Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp:62
>          m_bytesAllocated -= bytesFreed;

As above.
Comment 3 WebKit Review Bot 2012-08-27 13:20:30 PDT 
Comment on attachment 160767 [details]
Patch

Clearing flags on attachment: 160767

Committed r126787: <http://trac.webkit.org/changeset/126787>
Comment 4 WebKit Review Bot 2012-08-27 13:20:33 PDT 
All reviewed patches have been landed.  Closing bug.