Bug 95050 - WebKit fails to compile with both Qt+Wince support enabled
Summary: WebKit fails to compile with both Qt+Wince support enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-26 23:52 PDT by Kevin Funk
Modified: 2012-08-27 12:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2012-08-27 00:00 PDT, Kevin Funk 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (1.81 KB, patch)
2012-08-27 01:34 PDT, Kevin Funk 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Funk 2012-08-26 23:52:17 PDT 
The problem is in NativeImagePtr.h, when both OS(WINCE) and PLATFORM(QT) are true.

The file is split into declaration + typedef part - the first part assumes Qt platform support, the second one support for WinCE, which leads to a compile error.

Patch follows.
Comment 1 Kevin Funk 2012-08-27 00:00:40 PDT 
Created attachment 160652 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-27 00:03:06 PDT 
Attachment 160652 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/NativeImagePtr.h:31:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 kov's GTK+ EWS bot 2012-08-27 00:20:40 PDT 
Comment on attachment 160652 [details]
Patch

Attachment 160652 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13601992
Comment 4 Kevin Funk 2012-08-27 01:34:34 PDT 
Created attachment 160663 [details]
Patch v2
Comment 5 WebKit Review Bot 2012-08-27 12:06:32 PDT 
Comment on attachment 160663 [details]
Patch v2

Clearing flags on attachment: 160663

Committed r126783: <http://trac.webkit.org/changeset/126783>
Comment 6 WebKit Review Bot 2012-08-27 12:06:35 PDT 
All reviewed patches have been landed.  Closing bug.