Bug 94901 - [V8] Improve the developer ergonomics of ScopedPersistent
Summary: [V8] Improve the developer ergonomics of ScopedPersistent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 23:02 PDT by Adam Barth
Modified: 2012-08-24 02:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.93 KB, patch)
2012-08-23 23:06 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-04 (376.66 KB, application/zip)
2012-08-24 00:15 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-23 23:02:17 PDT
[V8] Improve the developer ergonomics of ScopedPersistent
Comment 1 Adam Barth 2012-08-23 23:06:24 PDT
Created attachment 160334 [details]
Patch
Comment 2 Kentaro Hara 2012-08-23 23:10:19 PDT
Comment on attachment 160334 [details]
Patch

Thanks for the great ergonomics
Comment 3 WebKit Review Bot 2012-08-24 00:14:58 PDT
Comment on attachment 160334 [details]
Patch

Rejecting attachment 160334 [details] from commit-queue.

New failing tests:
http/tests/cache/post-with-cached-subresources.php
Full output: http://queues.webkit.org/results/13593067
Comment 4 WebKit Review Bot 2012-08-24 00:15:01 PDT
Created attachment 160349 [details]
Archive of layout-test-results from gce-cq-04

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 5 WebKit Review Bot 2012-08-24 02:26:54 PDT
Comment on attachment 160334 [details]
Patch

Clearing flags on attachment: 160334

Committed r126564: <http://trac.webkit.org/changeset/126564>
Comment 6 WebKit Review Bot 2012-08-24 02:26:57 PDT
All reviewed patches have been landed.  Closing bug.