Bug 94647 - Web Inspector: [regression] Settings panel fails to open
Summary: Web Inspector: [regression] Settings panel fails to open
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 16:39 PDT by johnjbarton
Modified: 2012-08-21 19:39 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2012-08-21 19:37 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2012-08-21 16:39:16 PDT
After
Bug 94416 - Web Inspector: load scripts panel lazily
the Settings fails to open unless the user happens to open the Sources panel first.

SettingScreen.js uses WebInspector.settings.searchInContentScripts

    p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Search in content scripts"), WebInspector.settings.searchInContentScripts));

But the value is not define until ScriptsPanel.js imports ScriptsSearchScope.js

Source/WebCore/inspector/front-end/ScriptsPanel.js:importScript("ScriptsSearchScope.js");

which creates the setting:

WebInspector.settings.searchInContentScripts = WebInspector.settings.createSetting("searchInContentScripts", false);
Comment 1 Pavel Feldman 2012-08-21 19:20:10 PDT
I'l fix it right away. Now that it squeezed into the Canary, the workaround is to open Sources tab first. Then settings will open.
Comment 2 Pavel Feldman 2012-08-21 19:37:49 PDT
Created attachment 159844 [details]
Patch
Comment 3 Pavel Feldman 2012-08-21 19:39:44 PDT
Committed r126253: <http://trac.webkit.org/changeset/126253>