Bug 94484 – Web Inspector: TabbedPane: measure tab widths in batches.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Otherwise we do N (number of tabs) reflows while measuring.

[Pavel Feldman]

Created attachment 159444 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 159444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159444&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:188
> +    this._editorContainer.setCoalescingUpdate(true);

start/endBatchUpdate or enter/exitBatchUpdate

> Source/WebCore/inspector/front-end/TabbedPane.js:395
> +            measuringTabElement.__tab = tab;

Use map or another array?

[Pavel Feldman]

Created attachment 159695 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159695 [details]
Patch

Rejecting attachment 159695 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
to file Source/WebCore/inspector/front-end/utilities.js.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/start-end-batch-update-expected.txt
patching file LayoutTests/inspector/start-end-batch-update.html
patching file LayoutTests/inspector/tabbed-pane-tabs-to-show.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Vsevolod V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13559075

[Pavel Feldman]

Committed r126268: <http://trac.webkit.org/changeset/126268>