Bug 94484 - Web Inspector: TabbedPane: measure tab widths in batches.
Summary: Web Inspector: TabbedPane: measure tab widths in batches.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-08-20 09:00 PDT by Pavel Feldman
Modified: 2012-08-21 23:58 PDT (History)
11 users (show)

See Also:

Patch (10.78 KB, patch)
2012-08-20 09:06 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (20.01 KB, patch)
2012-08-21 08:28 PDT, Pavel Feldman
vsevik: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-20 09:00:29 PDT
Otherwise we do N (number of tabs) reflows while measuring.
Comment 1 Pavel Feldman 2012-08-20 09:06:17 PDT
Created attachment 159444 [details]
Comment 2 Vsevolod Vlasov 2012-08-21 05:48:39 PDT
Comment on attachment 159444 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=159444&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:188
> +    this._editorContainer.setCoalescingUpdate(true);

start/endBatchUpdate or enter/exitBatchUpdate

> Source/WebCore/inspector/front-end/TabbedPane.js:395
> +            measuringTabElement.__tab = tab;

Use map or another array?
Comment 3 Pavel Feldman 2012-08-21 08:28:42 PDT
Created attachment 159695 [details]
Comment 4 WebKit Review Bot 2012-08-21 16:56:11 PDT
Comment on attachment 159695 [details]

Rejecting attachment 159695 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
to file Source/WebCore/inspector/front-end/utilities.js.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/start-end-batch-update-expected.txt
patching file LayoutTests/inspector/start-end-batch-update.html
patching file LayoutTests/inspector/tabbed-pane-tabs-to-show.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Vsevolod V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13559075
Comment 5 Pavel Feldman 2012-08-21 23:58:23 PDT
Committed r126268: <http://trac.webkit.org/changeset/126268>