Bug 94474 - Update canvas tests that are using CanvasPixelArray
Summary: Update canvas tests that are using CanvasPixelArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 05:57 PDT by Thiago Marcos P. Santos
Modified: 2012-08-20 08:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2012-08-20 06:09 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2012-08-20 07:00 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-20 05:57:43 PDT
CanvasPixelArray is deprecated and we use Uint8ClampedArray now.
http://www.whatwg.org/specs/web-apps/current-work/#uint8clampedarray

W3C already update the approved tests using CanvasPixelArray.
http://dvcs.w3.org/hg/html/rev/2aea5b0c16f8
Comment 1 Thiago Marcos P. Santos 2012-08-20 06:09:04 PDT
Created attachment 159406 [details]
Patch
Comment 2 Andreas Kling 2012-08-20 06:13:19 PDT
Comment on attachment 159406 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-08-20 06:50:40 PDT
Comment on attachment 159406 [details]
Patch

Rejecting attachment 159406 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13530958
Comment 4 Thiago Marcos P. Santos 2012-08-20 07:00:29 PDT
Created attachment 159418 [details]
Patch

Rebased.
Comment 5 WebKit Review Bot 2012-08-20 08:05:14 PDT
Comment on attachment 159418 [details]
Patch

Clearing flags on attachment: 159418

Committed r126027: <http://trac.webkit.org/changeset/126027>
Comment 6 WebKit Review Bot 2012-08-20 08:05:19 PDT
All reviewed patches have been landed.  Closing bug.