WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94233
[Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime().
https://bugs.webkit.org/show_bug.cgi?id=94233
Summary
[Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime().
David Reveman
Reported
2012-08-16 11:21:17 PDT
Rename virtual function CCDelayBasedTimeSource::monotonicallyIncreasingTime() that exist for testing purposes to CCDelayBasedTimeSource::monotonicTimeNow().
Attachments
Patch
(16.50 KB, patch)
2012-08-16 11:23 PDT
,
David Reveman
no flags
Details
Formatted Diff
Diff
Patch
(16.26 KB, patch)
2012-08-16 11:38 PDT
,
David Reveman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
David Reveman
Comment 1
2012-08-16 11:23:58 PDT
Created
attachment 158858
[details]
Patch
James Robinson
Comment 2
2012-08-16 11:27:51 PDT
Comment on
attachment 158858
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=158858&action=review
Thanks!
> Source/WebKit/chromium/tests/CCSchedulerTestCommon.h:130 > + virtual double monotonicTimeNow() const { return m_monotonicTimeNow; }
since you're here, can you add an OVERRIDE?
David Reveman
Comment 3
2012-08-16 11:38:09 PDT
Created
attachment 158865
[details]
Patch Add missing OVERRIDE
WebKit Review Bot
Comment 4
2012-08-16 12:54:16 PDT
Comment on
attachment 158865
[details]
Patch Clearing flags on attachment: 158865 Committed
r125802
: <
http://trac.webkit.org/changeset/125802
>
WebKit Review Bot
Comment 5
2012-08-16 12:54:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug