Bug 94155 - [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
Summary: [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-08-15 15:24 PDT by Xianzhu Wang
Modified: 2012-08-15 17:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2012-08-15 16:35 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-08-15 15:24:42 PDT
On Android we have bigger timeout (10s for normal tests and 50s for slow tests) because of low power CPUs. However DumpRenderTree hard-coded 30s timeout, so DumpRenderTree will timeout before NRWT timeout if the test need more than 30s. Such timeouts are treated as crashes for now.

A temporary resolution is to force no_timeout for DumpRenderTree before DumpRenderTree has the --timeout parameter (bug 76662).
Comment 1 Xianzhu Wang 2012-08-15 16:35:54 PDT
Created attachment 158659 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-15 17:38:23 PDT
Comment on attachment 158659 [details]
Patch

Clearing flags on attachment: 158659

Committed r125726: <http://trac.webkit.org/changeset/125726>
Comment 3 WebKit Review Bot 2012-08-15 17:38:27 PDT
All reviewed patches have been landed.  Closing bug.