Bug 94106 - [Qt] Make sure that we don't prematurely force the first layout during loading.
Summary: [Qt] Make sure that we don't prematurely force the first layout during loading.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 07:14 PDT by Jocelyn Turcotte
Modified: 2012-08-16 08:30 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-08-15 07:16 PDT, Jocelyn Turcotte
kenneth: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-08-15 07:14:23 PDT
[Qt] Make sure that we don't prematurely force the first layout during loading.
Comment 1 Jocelyn Turcotte 2012-08-15 07:16:35 PDT
Created attachment 158564 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-15 07:17:26 PDT
Comment on attachment 158564 [details]
Patch

Good catch!
Comment 3 Jocelyn Turcotte 2012-08-15 07:20:52 PDT
r+ed in 51 seconds!
I think it's a record :)
Comment 4 Kenneth Rohde Christiansen 2012-08-15 07:28:49 PDT
(In reply to comment #3)
> r+ed in 51 seconds!
> I think it's a record :)

Heh! I opened the bug report before you attached the patch, so I was prepared :-)
Comment 5 Build Bot 2012-08-15 08:54:18 PDT
Comment on attachment 158564 [details]
Patch

Attachment 158564 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13502743
Comment 6 Jocelyn Turcotte 2012-08-16 01:20:28 PDT
(In reply to comment #5)
> (From update of attachment 158564 [details])
> Attachment 158564 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/13502743

The bot is probably sick, this error doesn't make sense if the compile step passed and FrameView::forceLayout is getting linked.
Comment 7 Jocelyn Turcotte 2012-08-16 08:30:57 PDT
Committed r125781: <http://trac.webkit.org/changeset/125781>