Bug 94033 - Rename window.internals.fastMallocStatistics to mallocStatistics
Summary: Rename window.internals.fastMallocStatistics to mallocStatistics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 16:03 PDT by Scott Graham
Modified: 2012-08-15 12:08 PDT (History)
10 users (show)

See Also:

Attachments
Patch (35.74 KB, patch)
2012-08-14 16:08 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
update changelog (35.84 KB, patch)
2012-08-14 16:11 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
rebase (35.85 KB, patch)
2012-08-14 16:30 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-03 (370.70 KB, application/zip)
2012-08-14 18:24 PDT, WebKit Review Bot 		no flags Details
add forgotten rebase (36.48 KB, patch)
2012-08-15 09:14 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
sigh, remove oops in ChangeLog (36.44 KB, patch)
2012-08-15 11:03 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-08-14 16:03:59 PDT 
Rename window.internals.fastMallocStatistics to mallocStatistics
Comment 1 Scott Graham 2012-08-14 16:08:32 PDT 
Created attachment 158434 [details]
Patch
Comment 2 Scott Graham 2012-08-14 16:10:00 PDT 
In preparation for plumbing chromium's TCMalloc memory allocation information, in preparation for writing a layout test to prevent memory leaks in internal caches.
Comment 3 Scott Graham 2012-08-14 16:11:17 PDT 
Created attachment 158435 [details]
update changelog
Comment 4 Scott Graham 2012-08-14 16:30:35 PDT 
Created attachment 158439 [details]
rebase
Comment 5 WebKit Review Bot 2012-08-14 18:24:21 PDT 
Comment on attachment 158439 [details]
rebase

Attachment 158439 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13505133

New failing tests:
fast/harness/fastmallocstatistics-object.html
Comment 6 WebKit Review Bot 2012-08-14 18:24:27 PDT 
Created attachment 158472 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Scott Graham 2012-08-15 09:14:22 PDT 
Created attachment 158577 [details]
add forgotten rebase
Comment 8 Scott Graham 2012-08-15 09:14:47 PDT 
er, "rebaseline" (not "rebase")
Comment 9 WebKit Review Bot 2012-08-15 10:59:05 PDT 
Comment on attachment 158577 [details]
add forgotten rebase

Rejecting attachment 158577 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13515066
Comment 10 Scott Graham 2012-08-15 11:03:10 PDT 
Created attachment 158594 [details]
sigh, remove oops in ChangeLog
Comment 11 WebKit Review Bot 2012-08-15 12:08:22 PDT 
Comment on attachment 158594 [details]
sigh, remove oops in ChangeLog

Clearing flags on attachment: 158594

Committed r125691: <http://trac.webkit.org/changeset/125691>
Comment 12 WebKit Review Bot 2012-08-15 12:08:29 PDT 
All reviewed patches have been landed.  Closing bug.