Bug 93858 - Web Inspector: remove commitEditing from the text editor delegate.
Summary: Web Inspector: remove commitEditing from the text editor delegate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 09:29 PDT by Pavel Feldman
Modified: 2012-08-13 13:05 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2012-08-13 09:31 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2012-08-13 09:43 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-01 (565.17 KB, application/zip)
2012-08-13 11:01 PDT, WebKit Review Bot 		no flags Details
Patch (5.58 KB, patch)
2012-08-13 11:21 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-13 09:29:05 PDT 
This should be up to source frame.
Comment 1 Pavel Feldman 2012-08-13 09:31:44 PDT 
Created attachment 158015 [details]
Patch
Comment 2 Pavel Feldman 2012-08-13 09:43:37 PDT 
Created attachment 158023 [details]
Patch
Comment 3 WebKit Review Bot 2012-08-13 11:01:24 PDT 
Comment on attachment 158023 [details]
Patch

Rejecting attachment 158023 [details] from commit-queue.

New failing tests:
inspector/styles/css-live-edit.html
Full output: http://queues.webkit.org/results/13493174
Comment 4 WebKit Review Bot 2012-08-13 11:01:29 PDT 
Created attachment 158044 [details]
Archive of layout-test-results from gce-cq-01

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 5 Pavel Feldman 2012-08-13 11:21:31 PDT 
Created attachment 158054 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-13 13:05:28 PDT 
Comment on attachment 158054 [details]
Patch

Clearing flags on attachment: 158054

Committed r125438: <http://trac.webkit.org/changeset/125438>
Comment 7 WebKit Review Bot 2012-08-13 13:05:32 PDT 
All reviewed patches have been landed.  Closing bug.