Bug 93682 - [V8] Remove collectIsolatedContexts() from V8Proxy
Summary: [V8] Remove collectIsolatedContexts() from V8Proxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-08-09 20:27 PDT by Kentaro Hara
Modified: 2012-08-10 08:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2012-08-09 20:29 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (3.97 KB, patch)
2012-08-10 06:00 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-09 20:27:47 PDT 
We want to remove V8Proxy. In this bug we remove V8Proxy::collectIsolatedContexts().
Comment 1 Kentaro Hara 2012-08-09 20:29:28 PDT 
Created attachment 157624 [details]
Patch
Comment 2 Adam Barth 2012-08-10 00:58:19 PDT 
Comment on attachment 157624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157624&action=review

> Source/WebCore/bindings/v8/V8Proxy.cpp:670
>  void V8Proxy::collectIsolatedContexts(Vector<std::pair<ScriptState*, SecurityOrigin*> >& result)
>  {

Should we remove the function itself?
Comment 3 Kentaro Hara 2012-08-10 06:00:40 PDT 
Created attachment 157719 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-08-10 08:16:38 PDT 
Comment on attachment 157719 [details]
patch for landing

Clearing flags on attachment: 157719

Committed r125279: <http://trac.webkit.org/changeset/125279>