Bug 93588 - [BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
Summary: [BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
URL:
Keywords:
Depends on:
Blocks: 93324
  Show dependency treegraph
 
Reported: 2012-08-09 01:01 PDT by Jonathan Dong
Modified: 2012-08-12 21:35 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2012-08-09 01:08 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff
Patch (3.09 KB, patch)
2012-08-10 05:34 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-08-09 01:01:26 PDT
In BlackBerry porting we should use MediaPlayer::userAgent() in class MediaPlayerPrivate instead of retrieving the user agent string via the abstraction layer breaking way.
Comment 1 Jonathan Dong 2012-08-09 01:08:28 PDT
Created attachment 157414 [details]
Patch
Comment 2 Antonio Gomes 2012-08-09 10:14:20 PDT
Comment on attachment 157414 [details]
Patch

I think it looks ok.
Comment 3 WebKit Review Bot 2012-08-09 10:21:07 PDT
Comment on attachment 157414 [details]
Patch

Rejecting attachment 157414 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13458718
Comment 4 Jonathan Dong 2012-08-10 05:34:19 PDT
Created attachment 157714 [details]
Patch
Comment 5 Charles Wei 2012-08-12 17:15:39 PDT
Comment on attachment 157714 [details]
Patch

commit.
Comment 6 WebKit Review Bot 2012-08-12 21:35:55 PDT
Comment on attachment 157714 [details]
Patch

Clearing flags on attachment: 157714

Committed r125388: <http://trac.webkit.org/changeset/125388>
Comment 7 WebKit Review Bot 2012-08-12 21:35:59 PDT
All reviewed patches have been landed.  Closing bug.