WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93588
[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
https://bugs.webkit.org/show_bug.cgi?id=93588
Summary
[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to ...
Jonathan Dong
Reported
2012-08-09 01:01:26 PDT
In BlackBerry porting we should use MediaPlayer::userAgent() in class MediaPlayerPrivate instead of retrieving the user agent string via the abstraction layer breaking way.
Attachments
Patch
(3.06 KB, patch)
2012-08-09 01:08 PDT
,
Jonathan Dong
no flags
Details
Formatted Diff
Diff
Patch
(3.09 KB, patch)
2012-08-10 05:34 PDT
,
Jonathan Dong
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Dong
Comment 1
2012-08-09 01:08:28 PDT
Created
attachment 157414
[details]
Patch
Antonio Gomes
Comment 2
2012-08-09 10:14:20 PDT
Comment on
attachment 157414
[details]
Patch I think it looks ok.
WebKit Review Bot
Comment 3
2012-08-09 10:21:07 PDT
Comment on
attachment 157414
[details]
Patch Rejecting
attachment 157414
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/13458718
Jonathan Dong
Comment 4
2012-08-10 05:34:19 PDT
Created
attachment 157714
[details]
Patch
Charles Wei
Comment 5
2012-08-12 17:15:39 PDT
Comment on
attachment 157714
[details]
Patch commit.
WebKit Review Bot
Comment 6
2012-08-12 21:35:55 PDT
Comment on
attachment 157714
[details]
Patch Clearing flags on attachment: 157714 Committed
r125388
: <
http://trac.webkit.org/changeset/125388
>
WebKit Review Bot
Comment 7
2012-08-12 21:35:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug