Bug 93289 - If the Apple Java plug-in is blocked and no runtime is installed, don't load it
Summary: If the Apple Java plug-in is blocked and no runtime is installed, don't load it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 12:15 PDT by Anders Carlsson
Modified: 2012-08-06 13:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (168.75 KB, patch)
2012-08-06 12:36 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (169.49 KB, patch)
2012-08-06 12:47 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-08-06 12:15:47 PDT
If the Apple Java plug-in is blocked and no runtime is installed, don't load it
Comment 1 Anders Carlsson 2012-08-06 12:36:01 PDT
Created attachment 156744 [details]
Patch
Comment 2 Anders Carlsson 2012-08-06 12:47:28 PDT
Created attachment 156748 [details]
Patch
Comment 3 mitz 2012-08-06 13:38:07 PDT
Comment on attachment 156748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156748&action=review

> Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:128
> +        // If the Apple Java plug-in is block and we don't have a Java runtime installed, just pretend that the plug-in doesn't exist.

Typo: “block”.

> WebKitLibraries/ChangeLog:13
> +        * libWebKitSystemInterfaceSnowLeopard.a:

I don’t think this one is needed.
Comment 4 Anders Carlsson 2012-08-06 13:42:45 PDT
Committed r124799: <http://trac.webkit.org/changeset/124799>