Bug 93266 - Refactor emit*Inst functions and introduce toARMWord functions in DFG-JIT's traditional ARM port
Summary: Refactor emit*Inst functions and introduce toARMWord functions in DFG-JIT's t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 06:52 PDT by Gabor Ballabas
Modified: 2012-08-07 01:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (24.29 KB, patch)
2012-08-06 07:02 PDT, Gabor Ballabas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Ballabas 2012-08-06 06:52:21 PDT
First part of a bigger refactoring issue trying to make traditional ARM DFG-JIT port easier to read and understand.
Comment 1 Gabor Ballabas 2012-08-06 07:02:33 PDT
Created attachment 156684 [details]
Patch
Comment 2 Gyuyoung Kim 2012-08-06 09:12:53 PDT
Comment on attachment 156684 [details]
Patch

Attachment 156684 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13436752
Comment 3 Gabor Loki 2012-08-07 00:05:25 PDT
(In reply to comment #1)
> Created an attachment (id=156684) [details]

It looks good to me.
Comment 4 Csaba Osztrogonác 2012-08-07 01:32:59 PDT
Comment on attachment 156684 [details]
Patch

LGTM, r=me.
Comment 5 WebKit Review Bot 2012-08-07 01:50:58 PDT
Comment on attachment 156684 [details]
Patch

Clearing flags on attachment: 156684

Committed r124869: <http://trac.webkit.org/changeset/124869>
Comment 6 WebKit Review Bot 2012-08-07 01:51:02 PDT
All reviewed patches have been landed.  Closing bug.