Bug 93104 - [CMake][WIN] Disable C++ exceptions and RTTI
Summary: [CMake][WIN] Disable C++ exceptions and RTTI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-03 06:08 PDT by Patrick R. Gansterer
Modified: 2012-08-03 14:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2012-08-03 06:23 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-08-03 06:08:29 PDT
[CMake][WIN] Disable C++ exceptions and RTTI
Comment 1 Patrick R. Gansterer 2012-08-03 06:23:54 PDT
Created attachment 156347 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-08-03 06:58:03 PDT
Comment on attachment 156347 [details]
Patch

LGTM from a build system point of view. Personally, I'd send the /MP change in a separate patch.
Comment 3 Ryosuke Niwa 2012-08-03 13:16:34 PDT
Comment on attachment 156347 [details]
Patch

rs=me. (rubber stamp).
Comment 4 WebKit Review Bot 2012-08-03 14:10:43 PDT
Comment on attachment 156347 [details]
Patch

Clearing flags on attachment: 156347

Committed r124651: <http://trac.webkit.org/changeset/124651>
Comment 5 WebKit Review Bot 2012-08-03 14:10:48 PDT
All reviewed patches have been landed.  Closing bug.