Bug 93091 - [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
Summary: [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on: 93155
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-08-03 04:55 PDT by Tommy Widenflycht
Modified: 2012-08-22 12:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.91 KB, patch)
2012-08-03 05:22 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (12.27 KB, patch)
2012-08-22 06:15 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-08-03 04:55:44 PDT
Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree, to complete the infrastructure for RTCPeerConnection.
Comment 1 Tommy Widenflycht 2012-08-03 05:22:21 PDT
Created attachment 156335 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-03 11:18:15 PDT
Comment on attachment 156335 [details]
Patch

Clearing flags on attachment: 156335

Committed r124628: <http://trac.webkit.org/changeset/124628>
Comment 3 WebKit Review Bot 2012-08-03 11:18:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2012-08-03 13:57:46 PDT
Re-opened since this is blocked by 93155
Comment 5 Dmitry Titov 2012-08-03 13:59:30 PDT
I'm going to rollout this patch, starting from it there are random crashes on peerconnection-* and SessionDescription.html tests:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fmediastream%2FSessionDescription.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fmediastream%2Fpeerconnection-addstream.html
Comment 6 Dmitry Titov 2012-08-03 14:25:41 PDT
crash stack:
14:06:31.177 6226 worker/2 fast/multicol/column-break-with-balancing.html crashed, (stderr lines):
14:06:31.177 6226   	base::debug::StackTrace::StackTrace() [0x72c5ae]
14:06:31.178 6226   	base::(anonymous namespace)::StackDumpSignalHandler() [0x717479]
14:06:31.178 6226   	0x7f0b3705faf0
14:06:31.178 6226   	WebCore::RTCPeerConnectionHandlerChromium::~RTCPeerConnectionHandlerChromium() [0x1ddd6a5]
14:06:31.178 6226   	WebCore::RTCPeerConnection::~RTCPeerConnection() [0x1bb3eb3]
14:06:31.178 6226   	WebCore::DOMData::handleWeakObject<>() [0x105c40f]
14:06:31.178 6226   	WebCore::DOMDataStore::weakActiveDOMObjectCallback() [0x105c4b1]
14:06:31.178 6226   	v8::internal::GlobalHandles::PostGarbageCollectionProcessing() [0x823d53]
14:06:31.178 6226   	v8::internal::Heap::PerformGarbageCollection() [0x8436d8]
14:06:31.178 6226   	v8::internal::Heap::CollectGarbage() [0x843f6f]
14:06:31.178 6226   	v8::internal::SetAccessor() [0x829ef0]
14:06:31.178 6226   	v8::Object::SetAccessor() [0x7b0023]
14:06:31.178 6226   	WebCore::V8DOMWindow::installPerContextProperties() [0x13a1e86]
14:06:31.178 6226   	WebCore::V8DOMWindowShell::installDOMWindow() [0xd4ba05]
14:06:31.178 6226   	WebCore::V8DOMWindowShell::initContextIfNeeded() [0xd4c62c]
14:06:31.178 6226   	WebCore::V8DOMWindowShell::updateDocument() [0xd4c9ae]
14:06:31.178 6226   	WebCore::Frame::setDocument() [0xfabb32]
14:06:31.178 6226   	WebCore::DocumentWriter::begin() [0xf17159]
14:06:31.178 6226   	WebCore::DocumentLoader::commitData() [0xf0d6c9]
14:06:31.178 6226   	WebKit::FrameLoaderClientImpl::committedLoad() [0x4b2b50]
14:06:31.178 6226   	WebCore::DocumentLoader::commitLoad() [0xf0d886]
14:06:31.178 6226   	WebCore::ResourceLoader::didReceiveData() [0xf4e443]
14:06:31.179 6226   	WebCore::MainResourceLoader::didReceiveData() [0xf38b55]
14:06:31.179 6226   	WebCore::ResourceLoader::didReceiveData() [0xf4dfe5]
14:06:31.179 6226   	(anonymous namespace)::RequestProxy::NotifyReceivedData() [0x1744316]
14:06:31.179 6226   	MessageLoop::RunTask() [0x70c6de]
14:06:31.179 6226   	MessageLoop::DeferOrRunPendingTask() [0x70ce08]
14:06:31.179 6226   	MessageLoop::DoWork() [0x70d408]
14:06:31.179 6226   	base::MessagePumpGlib::HandleDispatch() [0x7270b9]
14:06:31.179 6226   	(anonymous namespace)::WorkSourceDispatch() [0x7270fd]
14:06:31.179 6226   	0x7f0b3a3208c2
14:06:31.179 6226   	0x7f0b3a324748
14:06:31.179 6226   	0x7f0b3a3248fc
14:06:31.179 6226   	base::MessagePumpGlib::RunWithDispatcher() [0x727500]
14:06:31.179 6226   	MessageLoop::RunInternal() [0x707d85]
14:06:31.179 6226   	base::RunLoop::Run() [0x7176bd]
14:06:31.179 6226   	MessageLoop::Run() [0x706be5]
14:06:31.179 6226   	TestShell::waitTestFinished() [0x43d8b5]
14:06:31.179 6226   	TestShell::runFileTest() [0x43bef5]
14:06:31.179 6226   	runTest() [0x41c138]
14:06:31.179 6226   	main [0x41c63e]
14:06:31.179 6226   	0x7f0b3704ac4d
14:06:31.180 6226   	0x41b379
Comment 7 Tommy Widenflycht 2012-08-22 06:15:13 PDT
Created attachment 159918 [details]
Patch
Comment 8 Tommy Widenflycht 2012-08-22 06:16:37 PDT
Fixed the issue that caused random crashes; a double-free bug in Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
Comment 9 WebKit Review Bot 2012-08-22 12:30:52 PDT
Comment on attachment 159918 [details]
Patch

Rejecting attachment 159918 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ource/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 DOM manipulation crashes the browser

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13569340
Comment 10 WebKit Review Bot 2012-08-22 12:55:12 PDT
Comment on attachment 159918 [details]
Patch

Clearing flags on attachment: 159918

Committed r126341: <http://trac.webkit.org/changeset/126341>
Comment 11 WebKit Review Bot 2012-08-22 12:55:15 PDT
All reviewed patches have been landed.  Closing bug.