Bug 92823 - Internals::setAuthorShadowDOMForAnyElementEnabled should be on InternalSettings
Summary: Internals::setAuthorShadowDOMForAnyElementEnabled should be on InternalSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 19:16 PDT by Hajime Morrita
Modified: 2012-07-31 23:12 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.07 KB, patch)
2012-07-31 19:41 PDT, Hajime Morrita 		haraken: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-07-31 19:16:19 PDT 
The API should be on InternalSettings to support restoring original.
Comment 1 Hajime Morrita 2012-07-31 19:41:23 PDT 
Created attachment 155705 [details]
Patch
Comment 2 Kentaro Hara 2012-07-31 19:44:24 PDT 
Comment on attachment 155705 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-07-31 21:49:32 PDT 
Comment on attachment 155705 [details]
Patch

Rejecting attachment 155705 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 media/video-currentTime-delay.html shouldn't be a performance test, so remove artificial deadline.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13394970
Comment 4 Hajime Morrita 2012-07-31 23:12:59 PDT 
Committed r124304: <http://trac.webkit.org/changeset/124304>