Bug 92704 - Rename WebKit2.h to WebKit2_C.h
Summary: Rename WebKit2.h to WebKit2_C.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-30 19:28 PDT by Sam Weinig
Modified: 2012-07-30 20:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (21.83 KB, patch)
2012-07-30 19:30 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Update file name. (21.83 KB, patch)
2012-07-30 20:08 PDT, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-07-30 19:28:57 PDT 
Rename WebKit2.h to WebKit2-C.h
Comment 1 Sam Weinig 2012-07-30 19:30:33 PDT 
Created attachment 155425 [details]
Patch
Comment 2 Sam Weinig 2012-07-30 19:30:58 PDT 
Comment on attachment 155425 [details]
Patch

Scratch that, let's use an underscore.
Comment 3 WebKit Review Bot 2012-07-30 19:37:28 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 WebKit Review Bot 2012-07-30 19:37:50 PDT 
Attachment 155425 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/C/WebKit2-C.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2012-07-30 20:08:37 PDT 
Created attachment 155427 [details]
Update file name.
Comment 6 Sam Weinig 2012-07-30 20:09:34 PDT 
I'm not completely sold on the name yet, but I need the WebKit2.h header now, so it will have to do.
Comment 7 WebKit Review Bot 2012-07-30 20:13:10 PDT 
Attachment 155427 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/API/C/WebKit2_C.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Sam Weinig 2012-07-30 20:16:04 PDT 
Committed r124163: <http://trac.webkit.org/changeset/124163>