RESOLVED FIXED Bug 92631
[BlackBerry] Adapt to changes in the SharedArray platform API 
https://bugs.webkit.org/show_bug.cgi?id=92631
Summary [BlackBerry] Adapt to changes in the SharedArray platform API
Robin Cao
Reported 2012-07-30 04:39:39 PDT
The SharedArray API in the platform has changed. We should adapt to these changes.
Attachments
patch (8.09 KB, patch)
2012-07-30 04:51 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-05 (654.21 KB, application/zip)
2012-07-30 07:06 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-07-30 04:41:14 PDT
CC
Robin Cao
Comment 2 2012-07-30 04:51:20 PDT
Created attachment 155261 [details] patch
Rob Buis
Comment 3 2012-07-30 04:55:49 PDT
Comment on attachment 155261 [details] patch LGTM.
WebKit Review Bot
Comment 4 2012-07-30 07:06:40 PDT
Comment on attachment 155261 [details] patch Attachment 155261 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13386469 New failing tests: platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/accelerated-drawing/alpha.html
WebKit Review Bot
Comment 5 2012-07-30 07:06:44 PDT
Created attachment 155283 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Joe Mason
Comment 6 2012-07-30 07:13:39 PDT
(In reply to comment #4) > (From update of attachment 155261 [details]) > Attachment 155261 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13386469 > > New failing tests: > platform/chromium/compositing/accelerated-drawing/svg-filters.html > platform/chromium/compositing/accelerated-drawing/alpha.html These failures were not caused by this patch.
Rob Buis
Comment 7 2012-07-30 07:14:07 PDT
(In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 155261 [details] [details]) > > Attachment 155261 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/13386469 > > > > New failing tests: > > platform/chromium/compositing/accelerated-drawing/svg-filters.html > > platform/chromium/compositing/accelerated-drawing/alpha.html > > These failures were not caused by this patch. I agree with Joe, will retry.
WebKit Review Bot
Comment 8 2012-07-30 08:55:09 PDT
Comment on attachment 155261 [details] patch Clearing flags on attachment: 155261 Committed r124031: <http://trac.webkit.org/changeset/124031>
WebKit Review Bot
Comment 9 2012-07-30 08:55:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.