Bug 92103 - HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
Summary: HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks: 91853
  Show dependency tree / graph
 
Reported: 2012-07-24 05:44 PDT by Dominik Röttsches (drott)
Modified: 2012-07-24 07:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2012-07-24 05:50 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Including header instead of fw declarations. (1.62 KB, patch)
2012-07-24 06:32 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-07-24 05:44:29 PDT 
I'd suggest to include the header instead.
Comment 1 Dominik Röttsches (drott) 2012-07-24 05:50:21 PDT 
Created attachment 154030 [details]
Patch
Comment 2 jochen 2012-07-24 06:00:02 PDT 
Comment on attachment 154030 [details]
Patch

The patch looks good

View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35
> +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0.

I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough.
Comment 3 Dominik Röttsches (drott) 2012-07-24 06:32:05 PDT 
Created attachment 154042 [details]
Including header instead of fw declarations.
Comment 4 Dominik Röttsches (drott) 2012-07-24 06:32:47 PDT 
(In reply to comment #2)
> (From update of attachment 154030 [details])
> The patch looks good
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review
> 
> > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35
> > +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0.
> 
> I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough.

Done. Thanks for taking a look.
Comment 5 WebKit Review Bot 2012-07-24 07:41:08 PDT 
Comment on attachment 154042 [details]
Including header instead of fw declarations.

Clearing flags on attachment: 154042

Committed r123475: <http://trac.webkit.org/changeset/123475>
Comment 6 WebKit Review Bot 2012-07-24 07:41:13 PDT 
All reviewed patches have been landed.  Closing bug.