Bug 92042 - Make RenderBlock::paintChildren virtual so sub classes can change the paint order
Summary: Make RenderBlock::paintChildren virtual so sub classes can change the paint o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 92041
  Show dependency treegraph
 
Reported: 2012-07-23 16:01 PDT by Tony Chang
Modified: 2012-07-24 13:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.24 KB, patch)
2012-07-23 16:05 PDT, Tony Chang
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-07-23 16:01:15 PDT
Make RenderBlock::paintChildren virtual so sub classes can change the paint order
Comment 1 Tony Chang 2012-07-23 16:05:22 PDT
Created attachment 153889 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-07-23 17:04:21 PDT
Perf impact?  I wouldn't expect there to be much of one...
Comment 3 Tony Chang 2012-07-24 11:41:47 PDT
(In reply to comment #2)
> Perf impact?  I wouldn't expect there to be much of one...

Good question.  I ran the moz page cycler on my machine and the difference appears to be in the noise.  I'll watch the page cyclers on the bots when I land this.
Comment 4 Tony Chang 2012-07-24 13:53:36 PDT
Committed r123524: <http://trac.webkit.org/changeset/123524>