Bug 9202 - CSS3: border-radius not completely implemented, testcase hangs webkit
Summary: CSS3: border-radius not completely implemented, testcase hangs webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: HasReduction, InRadar
: 10479 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-01 00:51 PDT by Joost de Valk (AlthA)
Modified: 2006-12-28 11:43 PST (History)
5 users (show)

See Also:

Attachments
Testcase (3.58 KB, text/html)
2006-06-01 00:52 PDT, Joost de Valk (AlthA) 		no flags Details
new test case... hangs my webkit (3.22 KB, text/html)
2006-08-01 13:05 PDT, Alexander Kellett 		no flags Details
sample of hang (12.43 KB, text/plain)
2006-08-14 13:31 PDT, Alice Liu 		no flags Details
Patch (139.54 KB, patch)
2006-12-26 08:18 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joost de Valk (AlthA) 2006-06-01 00:51:50 PDT 
the border-radius "subtypes" border-radius-topleft, border-radius-topright, border-radius-bottomleft and border-radius-bottomright are not implemented, as shown by the forthcoming testcase.
Comment 1 Joost de Valk (AlthA) 2006-06-01 00:52:18 PDT 
Created attachment 8634 [details]
Testcase
Comment 2 Joost de Valk (AlthA) 2006-06-01 00:52:44 PDT 
cc-ing Beth, as she fixed the other border-radius bugs.
Comment 3 Joost de Valk (AlthA) 2006-08-01 12:26:37 PDT 
This testcase is plain wrong :). Should be -webkit-border-top-left-radius etc. Only one not working seems to be bottom-right, but i'm researching that...
Comment 4 Alexander Kellett 2006-08-01 13:05:08 PDT 
Created attachment 9798 [details]
new test case... hangs my webkit
Comment 5 Alexander Kellett 2006-08-01 23:38:03 PDT 
making P1, this hangs webkit reproducibly
Comment 6 Alice Liu 2006-08-14 13:31:03 PDT 
Created attachment 10024 [details]
sample of hang

this is the end of the main thread:

696 WebCore::GraphicsContext::drawArc(WebCore::IntRect const&, float, int, int) 
  696 CGContextStrokePath 
    696 CGContextDrawPath 
      696 ripc_DrawPath 
        696 ripr_Path 
          696 CGPathApply 
            696 ripr_path_stroke 
              696 path_dash_iterate 
                696 cube_length 
                  696 cube_length
Comment 7 Alice Liu 2006-08-14 13:31:38 PDT 
whoa! what happened there?
Comment 8 Alice Liu 2006-08-14 13:44:20 PDT 
<rdar://problem/4680169>
Comment 9 David Kilzer (:ddkilzer) 2006-08-14 16:50:54 PDT 
(In reply to comment #7)
> whoa! what happened there?

Looks like a regression from Bug 9630, or are you using an old WebKit build, Alice?  The &#160; entity is the same as a non-breaking space entity (&nbsp;).  (See comment #6.)
Comment 10 mitz 2006-08-21 12:06:11 PDT 
*** Bug 10479 has been marked as a duplicate of this bug. ***
Comment 11 mitz 2006-08-21 12:09:24 PDT 
As far as I can tell, the hang is the only issue here (the original bug was invalid). As I mentioned in bug 10479, the problem is a consequence of division by zero in drawArc when it's asked to draw a zero-radius dashed arc. It ends up passing some huge value down to CG causing it to hand (I think someone said that it actually returns after 15 minutes).
Comment 12 mitz 2006-12-26 08:18:49 PST 
Created attachment 12031 [details]
Patch
Comment 13 Darin Adler 2006-12-27 22:08:27 PST 
Comment on attachment 12031 [details]
Patch

r=me
Comment 14 Sam Weinig 2006-12-28 11:43:52 PST 
Landed in r18456.