Bug 91708 - Enable CSS variables compile time flag in Chrome.
Summary: Enable CSS variables compile time flag in Chrome.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 20:58 PDT by Luke Macpherson
Modified: 2012-07-22 16:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2012-07-18 21:02 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-07-18 20:58:33 PDT
Enable CSS variables compile time flag in Chrome.
Comment 1 Luke Macpherson 2012-07-18 21:02:38 PDT
Created attachment 153171 [details]
Patch
Comment 2 Peter Beverloo 2012-07-19 02:24:58 PDT
The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)?
Comment 3 Dimitri Glazkov (Google) 2012-07-19 09:03:34 PDT
(In reply to comment #2)
> The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)?

As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot.
Comment 4 Peter Beverloo 2012-07-19 09:17:30 PDT
(In reply to comment #3)
> As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot.

Agreed. If the syntax updates will be made in the short term, can we postpone advertising the feature in chrome://flags/ until that?
Comment 5 Luke Macpherson 2012-07-19 16:05:48 PDT
You might be referring to the editor's draft. http://dev.w3.org/csswg/css-variables/
Right now I'm tracking the CSSWG working draft syntax. http://www.w3.org/TR/css-variables/

There is another WG meeting coming up in about 4 weeks, so hopefully we'll talk about it then and some of the editor's draft ideas will be propagated to the working draft.
Comment 6 Luke Macpherson 2012-07-19 16:25:59 PDT
Also, I don't think it will actually appear under chrome://flags/ without me doing some additional work in chrome.
Comment 7 WebKit Review Bot 2012-07-19 21:29:55 PDT
Comment on attachment 153171 [details]
Patch

Clearing flags on attachment: 153171

Committed r123176: <http://trac.webkit.org/changeset/123176>
Comment 8 WebKit Review Bot 2012-07-19 21:29:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Simon Fraser (smfr) 2012-07-22 09:55:13 PDT
Why was this just enabled in Chrome, and not in Mac builds? Most of the time we try to keep the features in sync.
Comment 10 Luke Macpherson 2012-07-22 16:53:50 PDT
I'm more than happy to flip it on if that's what you guys want. Note that this just flipped the compile flag, not the runtime flag, so there is no visible change to web pages yet, but it will help us get it stable and ready to turn on by default.