Bug 91708 – Enable CSS variables compile time flag in Chrome.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Enable CSS variables compile time flag in Chrome.

[Luke Macpherson]

Created attachment 153171 [details]
Patch

[Peter Beverloo]

The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)?

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)?

As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot.

[Peter Beverloo]

(In reply to comment #3)
> As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot.

Agreed. If the syntax updates will be made in the short term, can we postpone advertising the feature in chrome://flags/ until that?

[Luke Macpherson]

You might be referring to the editor's draft. http://dev.w3.org/csswg/css-variables/
Right now I'm tracking the CSSWG working draft syntax. http://www.w3.org/TR/css-variables/

There is another WG meeting coming up in about 4 weeks, so hopefully we'll talk about it then and some of the editor's draft ideas will be propagated to the working draft.

[Luke Macpherson]

Also, I don't think it will actually appear under chrome://flags/ without me doing some additional work in chrome.

[WebKit Review Bot]

Comment on attachment 153171 [details]
Patch

Clearing flags on attachment: 153171

Committed r123176: <http://trac.webkit.org/changeset/123176>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Why was this just enabled in Chrome, and not in Mac builds? Most of the time we try to keep the features in sync.

[Luke Macpherson]

I'm more than happy to flip it on if that's what you guys want. Note that this just flipped the compile flag, not the runtime flag, so there is no visible change to web pages yet, but it will help us get it stable and ready to turn on by default.