Bug 9114 - The file performance_test_results.html is missing after running atf
: The file performance_test_results.html is missing after running atf
Status: CLOSED FIXED
: WebKit
Tools / Tests
: 420+
: S60 Emulator S60 3rd edition
: P2 Normal
Assigned To:
:
: EasyFix, PlatformOnly
:
:
  Show dependency treegraph
 
Reported: 2006-05-25 12:03 PST by
Modified: 2006-07-28 10:59 PST (History)


Attachments
Updates WebUI to run perf test when -autotest specified (13.49 KB, patch)
2006-05-26 15:02 PST, Bradley Morrison
no flags Review Patch | Details | Formatted Diff | Diff
Runs performance tests when -autotest specified (24.84 KB, patch)
2006-05-30 13:41 PST, Bradley Morrison
no flags Review Patch | Details | Formatted Diff | Diff
Added Changlog to previous patch (25.37 KB, patch)
2006-05-30 14:58 PST, Bradley Morrison
zalan: review-
Review Patch | Details | Formatted Diff | Diff
Added Zalan's review changes to the patch (27.68 KB, patch)
2006-05-31 08:49 PST, Pat
no flags Review Patch | Details | Formatted Diff | Diff
Adding changelog (28.23 KB, patch)
2006-05-31 09:24 PST, Bradley Morrison
dacarson: review+
Review Patch | Details | Formatted Diff | Diff
Second pass at changes after review (AR2). Missed the typedef review comment. (28.38 KB, patch)
2006-05-31 10:42 PST, Pat
zalan: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2006-05-25 12:03:30 PST
The output from runatf is as follows:

Tested LayoutTests: 928
Failed LayoutTests: 0
Layout test results summary in X:/S60\LayoutTest_results.txt Performance results in X:/S60\performance_test_results.html

But there is no .html file, only the .txt
------- Comment #1 From 2006-05-25 12:38:28 PST -------
confirmed performance_test_results.html not copied to toplevel
------- Comment #2 From 2006-05-26 15:02:47 PST -------
Created an attachment (id=8564) [details]
Updates WebUI to run perf test when -autotest specified
------- Comment #3 From 2006-05-29 08:35:27 PST -------
Patch causes reindeer to crash on startup. Reverting patch fixes reindeer startup crash, so r- for the moment. 
------- Comment #4 From 2006-05-29 08:36:18 PST -------
(From update of attachment 8564 [details])
Patch seems to crash reindeer at startup. Is it doing more than it needs to?
------- Comment #5 From 2006-05-30 13:41:21 PST -------
Created an attachment (id=8607) [details]
Runs performance tests when -autotest specified
------- Comment #6 From 2006-05-30 14:51:48 PST -------
(From update of attachment 8564 [details])
r=me

Zalan, please review.
------- Comment #7 From 2006-05-30 14:58:23 PST -------
Created an attachment (id=8609) [details]
Added Changlog to previous patch
------- Comment #8 From 2006-05-30 18:37:44 PST -------
(From update of attachment 8609 [details])
>if ( !err && 
please check for err == KErrNone (symbian coding convetion)

>numTestsRun->Des().Length()
use numTestsRun->Length() instead. ->Des() creates a copy of that descriptor.

>PrepPerformanceResultsFileL()
cleanupCount variable is not needed.

>(TDesC&)KRunAllTests() 
change DoAutomatedTestsActionL signature from TDesC& aActionString to const TDesC& aActionString. no need for typecast.
------- Comment #9 From 2006-05-31 08:49:29 PST -------
Created an attachment (id=8624) [details]
Added Zalan's review changes to the patch

This patch contains the changes recommended by Zalan's review.
------- Comment #10 From 2006-05-31 09:24:11 PST -------
Created an attachment (id=8625) [details]
Adding changelog
------- Comment #11 From 2006-05-31 09:25:40 PST -------
(In reply to comment #10)
> Created an attachment (id=8625) [edit] [details]
> Adding changelog
> 

Please add changelog (see patch for details)
Also when adding a new patch, click the obsolete button on earlier patches
Please request review of patches by setting review flag to ? & entering email address
------- Comment #12 From 2006-05-31 10:42:12 PST -------
Created an attachment (id=8627) [details]
Second pass at changes after review (AR2). Missed the typedef review comment.

Added the typedef changes mentioned in the review.
------- Comment #13 From 2006-05-31 10:47:16 PST -------
(From update of attachment 8627 [details])
Removed the typedefs in WebUiWindowContainer.cpp.  Where the call to DoAutomatedTestsActionL() is called.
------- Comment #14 From 2006-05-31 10:51:21 PST -------
(From update of attachment 8627 [details])
r=me
looks great!
------- Comment #15 From 2006-05-31 11:07:27 PST -------
committed r14648 & setting to FIXED.

Thanks!
------- Comment #16 From 2006-06-04 16:06:42 PST -------
(From update of attachment 8625 [details])
Marked the change log as review+ as the bug (and hopefully) the changlog has already been commited.
------- Comment #17 From 2006-06-26 06:34:24 PST -------
(From update of attachment 8564 [details])
Clearing the review flag on this to remove it from the review queue, since this patch was obsoleted.
------- Comment #18 From 2006-07-28 10:59:35 PST -------
Set to CLOSED.