Bug 90986 – Move nodesFromRect tests to separate directory

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Allan Sandfeld Jensen]

We are starting to get more tests using nodesFromRect. It would be convenient if they were all located in the same directory so they can be more easily tested or skipped collectively.

[Allan Sandfeld Jensen]

Created attachment 151719 [details]
Patch

[Antonio Gomes]

it seems you left this one out: webkit/LayoutTests/media/nodesFromRect-shadowContent.html

[Allan Sandfeld Jensen]

(In reply to comment #2)
> it seems you left this one out: webkit/LayoutTests/media/nodesFromRect-shadowContent.html

True, but isn't it in LayoutTests/media as opposed to LayoutTests/dom for a reason?

Or do you mean I need to edit it to the new paths?

[Allan Sandfeld Jensen]

Created attachment 151723 [details]
Patch

[Antonio Gomes]

(In reply to comment #3)
> (In reply to comment #2)
> > it seems you left this one out: webkit/LayoutTests/media/nodesFromRect-shadowContent.html
> 
> True, but isn't it in LayoutTests/media as opposed to LayoutTests/dom for a reason?
> 
> Or do you mean I need to edit it to the new paths?

mostly for convinience with the path. It seems some media tests are easier to code if in the /media dir. Like just moving the test and adjusting the paths in the test won't just work.

Maybe we should fix that too. I remember talking to Eric about it when the test was introduced.

[Antonio Gomes]

Comment on attachment 151723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151723&action=review

> LayoutTests/ChangeLog:24
> +        * media/nodesFromRect-shadowContent.html:

do we want to move this too?

> LayoutTests/platform/chromium/TestExpectations:2163
>  // We don't support layoutTestController.nodesFromRect so this test just times out

this is inaccurate now since it uses Internals. Maybe it will just work for most ports as is?

> LayoutTests/platform/win/Skipped:1303
>  # LayoutTestController::nodesFromRect is not supported.

ditto

> LayoutTests/platform/wincairo/Skipped:1818
>  # LayoutTestController::nodesFromRect is not supported.

ditto

> LayoutTests/platform/wk2/Skipped:-902
> -# WebKitTestRunner needs layoutTestController.nodesFromRect

ditto

[Allan Sandfeld Jensen]

(In reply to comment #6)
> (From update of attachment 151723 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151723&action=review
> 
> > LayoutTests/ChangeLog:24
> > +        * media/nodesFromRect-shadowContent.html:
> 
> do we want to move this too?
> 
That is a good question. I think it could be in either locations, so I will leave it where it is for now.

> > LayoutTests/platform/chromium/TestExpectations:2163
> >  // We don't support layoutTestController.nodesFromRect so this test just times out
> 
> this is inaccurate now since it uses Internals. Maybe it will just work for most ports as is?
> 
I suspect it will just work, but since Chrome has a separate bug for it, I will remove these entries in a patch closing that bug. It should also make it safer in case a revert is needed.

[Allan Sandfeld Jensen]

Created attachment 151961 [details]
Patch

[Allan Sandfeld Jensen]

Created attachment 151962 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 151962 [details]
Patch for landing

Clearing flags on attachment: 151962

Committed r122473: <http://trac.webkit.org/changeset/122473>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.